Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picked Python tests and updated upb dep #14443

Closed
wants to merge 2 commits into from

Conversation

haberman
Copy link
Member

This is a cherry-pick of b1c4c65, which was committed before the protobuf/upb repo split. The upb portion of that change was already cherry-picked. This PR cherry-picks the tests, and updates the upb dep so that these tests can pass.

@haberman haberman added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 17, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Oct 17, 2023
@acozzette
Copy link
Member

@haberman I just merged a couple fixes on the 22.x branch that should address the codespell and linkage monitor failures, so those should go away if you rebase and rerun the tests. I think we can ignore the C# failure because we're not planning on doing any further C# releases on 22.x.

@hlopko hlopko added the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Dec 12, 2023
@github-actions github-actions bot removed the 🅰️ safe for tests Mark a commit as safe to run presubmits over label Dec 12, 2023
@hlopko
Copy link
Contributor

hlopko commented Dec 12, 2023

Hi @haberman, is this PR still relevant?

@haberman haberman closed this Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants